Conversation
Replace the cloned desktop source and private renderer/store imports with immutable core, bridge-contract, and shared-domain packages. Android now owns its native storage, Cloud transport, gestures, and keyboard behavior while using public APIs for editor and workspace actions. - Coordinate native vault rename/move with save draining, workspace identity, reopen, and rollback. - Reject stale attachment and gesture contexts after a workspace transition. - Preserve SAF error distinctions for missing files, directories, revoked access, and provider failures. - Add package-boundary checks and disposable native runtime/provider fixtures. The vendored package set includes the v2.50.4 fixes. The Android application version is unchanged.
This was referenced Sep 16, 2026
The production audit used to run inside the desktop source checkout, whose root manifest overrides the nested nanoid and mermaid parser versions that Excalidraw pulls in. Installing the core as a package moved the audit into this repository, where no overrides existed, so the same dependency tree failed on high advisories against nanoid 3.3.3, nanoid 4.0.2, and lodash-es 4.17.21. Add the same overrides. npm keeps already-nested lockfile entries even when overrides change, so the stale nested entries were removed and the tree re-resolved: 21 packages drop out, the resolution matches the desktop, and the audit reports nothing. The lockfile is stable on a second resolve. The same change on the local tree with the newer core candidate passes the boundary check, typecheck, unit tests, and the production build.
adibhanna
marked this pull request as ready for review
September 16, 2026 20:07
Contributor
Author
|
Superseded by #69, which carries the same migration on the published core-2.51.0-core.h49d73b531d346192 archives (desktop commit 8ff2cb86, clean tree) plus the later native work, the dependabot bumps, and the 1.1.21 (versionCode 23) bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the cloned desktop source and private renderer/store imports with immutable core, bridge-contract, and shared-domain packages. Android now owns its native storage, Cloud transport, gestures, and keyboard behavior while using public APIs for editor and workspace actions.
The vendored package set includes the v2.50.4 fixes. The Android application version is unchanged.
Validation
Draft dependencies
Depends on the main ZenNotes public-package migration. The exact vendored archives are review candidates with dirty-source provenance; replace them with reviewed clean artifacts before release. Real account-backed Cloud acceptance remains a staging gate. No application release or deployment is included.
Related boundary PRs